[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] whitelist host virtio networking features [was Re:
From: |
Dustin Kirkland |
Subject: |
[Qemu-devel] [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...] |
Date: |
Thu, 29 Oct 2009 10:34:15 -0500 |
whitelist host virtio networking features
This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb,
fixing crashes when guests with 2.6.25 virtio drivers have saturated
virtio network connections.
https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/458521
That patch should have been whitelisting *_HOST_* rather than the the
*_GUEST_* features.
I tested this by running an Ubuntu 8.04 Hardy guest (2.6.24 kernel +
2.6.25-virtio driver). I saturated both the incoming, and outgoing
network connection with nc, seeing sustained 6MB/s up and 6MB/s down
bitrates for ~20 minutes. Previously, this crashed immediately. Now,
the guest does not crash and maintains network connectivity throughout
the test.
Signed-off-by: Dustin Kirkland <address@hidden>
Signed-off-by: Mark McLoughlin <address@hidden>
Tested-by: Dustin Kirkland <address@hidden>
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index ce8e6cb..27834fa 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -164,10 +164,10 @@ static uint32_t virtio_net_bad_features(VirtIODevice
*vdev)
/* Linux kernel 2.6.25. It understood MAC (as everyone must),
* but also these: */
features |= (1 << VIRTIO_NET_F_MAC);
- features |= (1 << VIRTIO_NET_F_GUEST_CSUM);
- features |= (1 << VIRTIO_NET_F_GUEST_TSO4);
- features |= (1 << VIRTIO_NET_F_GUEST_TSO6);
- features |= (1 << VIRTIO_NET_F_GUEST_ECN);
+ features |= (1 << VIRTIO_NET_F_CSUM);
+ features |= (1 << VIRTIO_NET_F_HOST_TSO4);
+ features |= (1 << VIRTIO_NET_F_HOST_TSO6);
+ features |= (1 << VIRTIO_NET_F_HOST_ECN);
return features & virtio_net_get_features(vdev);
}
signature.asc
Description: This is a digitally signed message part
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, (continued)
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Mark McLoughlin, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Dustin Kirkland, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Dustin Kirkland, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Mark McLoughlin, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Anthony Liguori, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Mark McLoughlin, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Dustin Kirkland, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Mark McLoughlin, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Dustin Kirkland, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Mark McLoughlin, 2009/10/29
- [Qemu-devel] [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...],
Dustin Kirkland <=
- [Qemu-devel] Re: [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...], Dustin Kirkland, 2009/10/30
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Dustin Kirkland, 2009/10/29
- Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Scott Tsai, 2009/10/29
[Qemu-devel] Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network, Michael S. Tsirkin, 2009/10/29
Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network, Dustin Kirkland, 2009/10/29