qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()
Date: Fri, 30 Oct 2009 12:46:28 -0500
User-agent: Thunderbird 2.0.0.23 (X11/20090825)

Mark McLoughlin wrote:
On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote:
Mark McLoughlin wrote:
Okay, let's try re-enabling the drain-entire-queue behaviour, with a
difference - before each subsequent packet, use qemu_can_send_packet()
to check that we can send it. This is similar to how we check before
polling the tap fd and avoids having to drop a packet if the receiver
cannot handle it.

This patch should be a performance improvement since we no longer have
to go through the mainloop for each packet.

Signed-off-by: Mark McLoughlin <address@hidden>
Could you rebase and rend this patch against master? I've got 1-4 in staging.

The GSO changes make resolving this non trivial (for me at least :-)).

Um, you've lost me :-)

You've got it in staging AFAICS, and anyway ... 5/5 is mostly a revert
of 1/5, so if 1/5 applied so should 5/5

What's in staging looks fine to me, except it doesn't build because of
problems with other patches

Ignore it, I accidentally tried backporting the patch targeted for the stable tree and then responded to the wrong patch.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]