[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/8] monitor: Convert qemu_chr_info() to QObject
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 6/8] monitor: Convert qemu_chr_info() to QObject |
Date: |
Sun, 1 Nov 2009 12:51:16 -0200 |
Each device is represented by a QDict. The returned QObject is a QList
of all devices.
The QDict contains the following:
- "label": device's label
- "filename": device's file
This commit should not change user output, the following is an
example of the returned QList:
[ { "label": "monitor", "filename", "stdio" },
{ "label": "serial0", "filename": "vc" } ]
Signed-off-by: Luiz Capitulino <address@hidden>
---
monitor.c | 3 ++-
qemu-char.c | 43 +++++++++++++++++++++++++++++++++++++++++--
qemu-char.h | 4 +++-
3 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index b9fed9f..4e19fdf 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1972,7 +1972,8 @@ static const mon_cmd_t info_cmds[] = {
.args_type = "",
.params = "",
.help = "show the character devices",
- .mhandler.info = qemu_chr_info,
+ .user_print = qemu_chr_print,
+ .mhandler.info_new = qemu_chr_info,
},
{
.name = "block",
diff --git a/qemu-char.c b/qemu-char.c
index 40bd7e8..fa23111 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -32,6 +32,7 @@
#include "hw/usb.h"
#include "hw/baum.h"
#include "hw/msmouse.h"
+#include "qemu-objects.h"
#include <unistd.h>
#include <fcntl.h>
@@ -2472,13 +2473,51 @@ void qemu_chr_close(CharDriverState *chr)
qemu_free(chr);
}
-void qemu_chr_info(Monitor *mon)
+static void qemu_chr_print_qlist(QObject *obj, void *opaque)
{
+ QDict *chr_dict;
+ Monitor *mon = opaque;
+
+ chr_dict = qobject_to_qdict(obj);
+ monitor_printf(mon, "%s: filename=%s\n", qdict_get_str(chr_dict, "label"),
+ qdict_get_str(chr_dict, "filename"));
+}
+
+void qemu_chr_print(Monitor *mon, const QObject *ret_data)
+{
+ qlist_iter(qobject_to_qlist(ret_data), qemu_chr_print_qlist, mon);
+}
+
+/**
+ * qemu_chr_info(): Character devices information
+ *
+ * Each device is represented by a QDict. The returned QObject is a QList
+ * of all devices.
+ *
+ * The QDict contains the following:
+ *
+ * - "label": device's label
+ * - "filename": device's file
+ *
+ * Example:
+ *
+ * [ { "label": "monitor", "filename", "stdio" },
+ * { "label": "serial0", "filename": "vc" } ]
+ */
+void qemu_chr_info(Monitor *mon, QObject **ret_data)
+{
+ QList *chr_list;
CharDriverState *chr;
+ chr_list = qlist_new();
+
QTAILQ_FOREACH(chr, &chardevs, next) {
- monitor_printf(mon, "%s: filename=%s\n", chr->label, chr->filename);
+ QObject *obj = qobject_from_jsonf("{ 'label': %s, 'filename': %s }",
+ NULL, chr->label, chr->filename);
+ qlist_append_obj(chr_list, obj);
}
+
+ *ret_data = QOBJECT(chr_list);
}
CharDriverState *qemu_chr_find(const char *name)
diff --git a/qemu-char.h b/qemu-char.h
index 05fe15d..1a7736f 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -5,6 +5,7 @@
#include "qemu-queue.h"
#include "qemu-option.h"
#include "qemu-config.h"
+#include "qobject.h"
/* character device */
@@ -88,7 +89,8 @@ int qemu_chr_can_read(CharDriverState *s);
void qemu_chr_read(CharDriverState *s, uint8_t *buf, int len);
int qemu_chr_get_msgfd(CharDriverState *s);
void qemu_chr_accept_input(CharDriverState *s);
-void qemu_chr_info(Monitor *mon);
+void qemu_chr_print(Monitor *mon, const QObject *ret_data);
+void qemu_chr_info(Monitor *mon, QObject **ret_data);
CharDriverState *qemu_chr_find(const char *name);
extern int term_escape_char;
--
1.6.5.2.101.gcd0f8
- [Qemu-devel] [RFC 0/8]: Some 'info' handlers conversions, Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 1/8] Introduce qemu-objects.h header file, Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 2/8] Makefile: move QObject objs to their own entry, Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 3/8] QDict: Introduce qdict_get_qbool(), Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 4/8] monitor: Convert do_info_migrate() to QObject, Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 5/8] monitor: Convert bdrv_info() to QObject, Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 6/8] monitor: Convert qemu_chr_info() to QObject,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 7/8] monitor: Convert pci_device_hot_add() to QObject, Luiz Capitulino, 2009/11/01
- [Qemu-devel] [PATCH 8/8] monitor: Convert do_info_status() to QObject, Luiz Capitulino, 2009/11/01