[Qemu-devel] Re: [PATCH 0/2] Build fixes

[Daniel Jacobowitz]

On Thu, Nov 05, 2009 at 02:42:51PM +0100, Juan Quintela wrote:
> Hi
> 
> This series fixes the parallel build of qemu.  I tried to get the best of
> Daniel and Stefan ideas with mine.
> Once there fixed an obvious fix.
> 
> Daniel, can you check that parallel build also works for you?  It works for 
> me (TM).

No, it doesn't work.

  GEN  config-all-devices.mak
  GEN   config-host.h
  GEN   config-all-devices.h
  CC    qemu-tool.o
  CC    cutils.o
In file included from /scratch/dan/qemu/src/qemu-trunk/qemu-tool.c:14:
/scratch/dan/qemu/src/qemu-trunk/qemu-common.h:32:25: error:
config-host.h: No such file or directory
make: *** [qemu-tool.o] Error 1

You have to define GENERATED_HEADERS before you use it in
dependencies, I believe.  But you've got it way down below the
rules.mak invocation.

Also, your changes to $(QEMU_PROG) and recurse-all are not necessary;
they're the same sort of ordering assumption that caused the original
bug.  You only need to depend on generated files if you're going to
use them in this rule's commands; for headers, that means invoke a .c
to .o compilation.  The dependencies should be on exactly the rules
that need them.

I didn't bother with Makefile.target since the headers are generated
in the top level and that make will remain recursive.

-- 
Daniel Jacobowitz
CodeSourcery