qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] don't look for libuuid on Darwin


From: C.W. Betts
Subject: Re: [Qemu-devel] don't look for libuuid on Darwin
Date: Mon, 9 Nov 2009 21:29:38 -0700


On Nov 9, 2009, at 12:22 PM, Christoph Hellwig wrote:

On Mon, Nov 09, 2009 at 11:46:13AM -0700, C.W. Betts wrote:
Does this work?

diff --git a/configure b/configure
index aa2cc43..00e04e9 100755
--- a/configure
+++ b/configure
@@ -1060,7 +1060,11 @@ fi
##########################################
# uuid_generate() probe, used for vdi block driver
if test "$uuid" != "no" ; then
-  uuid_libs="-luuid"
+  if test "$darwin" == "yes"; then
+    uuid_libs=""
+  else
+    uuid_libs="-luuid"
+  fi

It might work, but does Darwin really provide no libuuid at all?  I
thought it was just the static one that is missing?
The uuid definitions are in the libSystem library, which everything links against. LibSystem also includes libc, libm, pthreads, etc.

If it really is the case a comment above the test would help.

Also I think you should try to keep the mailinglist on Cc - it includes people that can provide valueable feedback, and also people that unlike
me can actually apply the patch to the qemu repository.
heh, sorry. I replied to the wrong message.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]