[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH V6 27/32] pci: teach pci_default_config_write()
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH V6 27/32] pci: teach pci_default_config_write() ROM bar for normal/bridge device . |
Date: |
Tue, 10 Nov 2009 18:01:06 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Fri, Oct 30, 2009 at 09:21:21PM +0900, Isaku Yamahata wrote:
> When updated ROM expantion address of header type 0, it missed
> to update mappings.
> Add PCI_ROM_ADDRESS check whether to call pci_update_mappings()
> Also update pci mapping when PCI_ROM_ADDRESS1 is written for header type 1.
>
> pci_update_mapping() path isn't performance critical,
> so call it even independent of header type.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
If possible please float this to start of series to I can
put on pci tree.
> ---
> hw/pci.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index d9fd564..46b22ec 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -707,6 +707,8 @@ void pci_default_write_config(PCIDevice *d, uint32_t
> addr, uint32_t val, int l)
> d->config[addr] = (d->config[addr] & ~wmask) | (val & wmask);
> }
> if (ranges_overlap(addr, l, PCI_BASE_ADDRESS_0, 24) ||
> + ranges_overlap(addr, l, PCI_ROM_ADDRESS, 4) ||
> + ranges_overlap(addr, l, PCI_ROM_ADDRESS1, 4) ||
> range_covers_byte(addr, l, PCI_COMMAND))
> pci_update_mappings(d);
> }
> --
> 1.6.0.2
>
>