Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

[Luiz Capitulino]

On Wed, 11 Nov 2009 01:52:12 +0800
Scott Tsai <address@hidden> wrote:

> On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino <address@hidden> wrote:
> >>
> >> I'd certainly like to make this code useful for something other than
> >> developer training.
> >> How about a new monitor command "thermometer_set" that works like 
> >> "mouse_move"?
> >> "thermometer_set" would just set the temperature of the "first"
> >> thermometer device it finds.
> >
> >  Couldn't the device be a parameter?
> >
> >  And I'd suggest usb_therm_set for the name.
> >
> 
> Looking at the existing "mouse_set" and "mouse_move" monitor commands,
> they work on USB, PS/2 and other kinds of mice with "mouse_set" selecting
> the mouse device affected by  "mouse_move".
> So how about a new command "therm_set" which selects the thermometer
> affected by "therm_temp" ?

 This mouse command also selects the current mouse, right?

 I think your case is simpler, you just want to say which thermometer
should get the new temp.

> On a separate note, I understand that if a piece of code is not useful enough
> we don't want to merge it to add to the maintenance burden.

 Alex has given a good reason to merge it, I think.