[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul |
Date: |
Wed, 11 Nov 2009 14:30:13 +0100 |
User-agent: |
Thunderbird 2.0.0.19 (X11/20081227) |
Gerd Hoffmann wrote:
> On 11/11/09 12:52, Hannes Reinecke wrote:
>> I still don't quite agree with the new scsi callback, which has
>> just the SCSIRequest as an argument. So when supporting more command
>> queueing we have no idea to which (internal) request structure
>> the SCSIRequest belongs, and still have to do a lookup.
>> Which is painful. Can we have a second 'void *arg' argument
>> to the callback which will allow us some driver specific
>> pointer?
>
> How about sticking a 'void *hba_private' element into SCSIRequest instead?
>
Would work for me, too.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
[Qemu-devel] Re: [sneak preview] major scsi overhaul, Gerd Hoffmann, 2009/11/11