Re: [Qemu-devel] [PATCH] Don't leak file descriptors

[Blue Swirl]

On Mon, Nov 16, 2009 at 2:47 PM, Kevin Wolf <address@hidden> wrote:
> Am 13.11.2009 22:05, schrieb Blue Swirl:
>> On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf <address@hidden> wrote:
>>> We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
>>> descriptors that don't need to be passed to children to stop this 
>>> misbehaviour.
>>
>>> -        c = accept(s, (struct sockaddr *)&addr, &addrlen);
>>> +        c = qemu_accept(s, (struct sockaddr *)&addr, &addrlen);
>>
>> Would it be possible to improve the interface so that no casts are
>> needed for the calling code?
>
> How exactly would you do that? The only way I see to do it would be
> using void*, but I'm not sure if this really is an improvement.

Instead of sockaddr_in vs. sockaddr and the lame casts in between, we
could have QSockAddr which magically works. Or if we only ever use
sockaddr_in, just use that.