|
| From: | Christoph Hellwig |
| Subject: | Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code. |
| Date: | Tue, 17 Nov 2009 12:50:47 +0100 |
| User-agent: | Mutt/1.3.28i |
The subject is a bit confusing - it's not the full request parsing but
just some helpers.
> +static int scsi_req_length(SCSIRequest *req, uint8_t *cmd)
> +{
> + switch (cmd[0] >> 5) {
I know qemu code tends to be very uncommented and the code this is
lifted from too, but some comments on how transfer and command length
related to the group in the higher bit of the command would be pretty
useful for the casual observer of this code.
| [Prev in Thread] | Current Thread | [Next in Thread] |