|
| From: | Paul Brook |
| Subject: | Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ. |
| Date: | Tue, 17 Nov 2009 11:59:54 +0000 |
| User-agent: | KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; ) |
On Tuesday 17 November 2009, Gerd Hoffmann wrote: > Changes: > * Move from open-coded lists to QTAILQ macros. > * Move the struct elements to the common data structures > (SCSIDevice + SCSIRequest). > * Fix request cleanup in the destroy callback. This feels like the abstraction boundaries wrong. If the request chain fields are in common structures then I'd also expect the allocation and linking code to be common. Paul
| [Prev in Thread] | Current Thread | [Next in Thread] |