Re: [Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap

[Alexander Graf]

Adam Lackorzynski wrote:
> On Wed Nov 18, 2009 at 15:33:10 +0100, Alexander Graf wrote:
>   
>> Adam Lackorzynski wrote:
>>     
>>> I need to following to fix multiboot booting for me.
>>>
>>> Should linuxboot.bin and multiboot.bin end up in pc-bios instead of
>>> pc-bios/optionrom?
>>>       
>>>              load_image(initrd_filename,
>>>                         mb_kernel_data + mb_mod_start - mh_load_addr);
>>>  
>>> @@ -720,7 +720,7 @@ static int load_multiboot(void *fw_cfg,
>>>      fw_cfg_add_bytes(fw_cfg, FW_CFG_INITRD_DATA, mb_bootinfo_data,
>>>                       sizeof(bootinfo));
>>>  
>>> -    option_rom[nb_option_roms] = "multiboot.bin";
>>> +    option_rom[nb_option_roms] = "optionrom/multiboot.bin";
>>>   
>>>       
>> This is wrong. The .bin file should be in pc-bios. It just doesn't get
>> copied over as part of the build process, but instead relies on the
>> committer to make sure the binary is updated on every source change.
>>     
>
> Ok, didn't know. Thank you both for clarifying! New patch attached.
>
>
> Signed-off-by: Adam Lackorzynski <address@hidden>
>   

Acked-by: Alexander Graf <address@hidden>



Alex