|
| From: | Paul Brook |
| Subject: | Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting |
| Date: | Fri, 20 Nov 2009 17:41:13 +0000 |
| User-agent: | KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; ) |
On Tuesday 17 November 2009, Gerd Hoffmann wrote: > Add a greeting string to CharDriverState which is printed after > initialization. Used to have the qemu vc consoles labeled. This > way we can avoid walking all the chardevs a second time after > initialization just to print the greeting. I think "greeting" is propagating a bad idea into new code. Much better would be some form of ID and/or human readable description that can also be used elsewhere. Paul
| [Prev in Thread] | Current Thread | [Next in Thread] |