qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] slirp: fix use-after-free


From: Mark McLoughlin
Subject: [Qemu-devel] [PATCH] slirp: fix use-after-free
Date: Fri, 20 Nov 2009 18:13:10 +0000

460fec67ee introduced a use-after free in slirp.

Cc: Jan Kiszka <address@hidden>
Signed-off-by: Mark McLoughlin <address@hidden>
---

Untested fix, but it's obvious.

Also, this is needed on stable-0.11.

 slirp/mbuf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/slirp/mbuf.c b/slirp/mbuf.c
index 7652fea..87508ba 100644
--- a/slirp/mbuf.c
+++ b/slirp/mbuf.c
@@ -95,8 +95,8 @@ m_free(struct mbuf *m)
         * Either free() it or put it on the free list
         */
        if (m->m_flags & M_DOFREE) {
-               free(m);
                m->slirp->mbuf_alloced--;
+               free(m);
        } else if ((m->m_flags & M_FREELIST) == 0) {
                insque(m,&m->slirp->m_freelist);
                m->m_flags = M_FREELIST; /* Clobber other flags */
-- 
1.6.2.5





reply via email to

[Prev in Thread] Current Thread [Next in Thread]