qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] net: initialize vnet_hdr in net_tap_init()


From: Mark McLoughlin
Subject: [Qemu-devel] [PATCH] net: initialize vnet_hdr in net_tap_init()
Date: Tue, 24 Nov 2009 10:05:04 +0000

Hi Pierre,

On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
> the kernel doesn't support IFF_VNET_HDR.

Thanks for the patch, but I'd prefer us to make sure we catch all cases.

Does this work for you?

Thanks,
Mark.

From: Mark McLoughlin <address@hidden>
Subject: [PATCH] net: initialize vnet_hdr in net_tap_init()

Don't assume that all tap_open() implementations will set it to
zero if VNET_HDR support isn't found.

Fixes tap networking on host kernels lacking IFF_VNET_HDR support.

Reported-by: Pierre Riteau <address@hidden>
Signed-off-by: Mark McLoughlin <address@hidden>
---
 net/tap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/tap.c b/net/tap.c
index d34feec..7fb9e16 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -378,7 +378,7 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr)
 int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState 
*vlan)
 {
     TAPState *s;
-    int fd, vnet_hdr;
+    int fd, vnet_hdr = 0;
 
     if (qemu_opt_get(opts, "fd")) {
         if (qemu_opt_get(opts, "ifname") ||
-- 
1.6.5.2





reply via email to

[Prev in Thread] Current Thread [Next in Thread]