qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test


From: Kevin O'Connor
Subject: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test
Date: Tue, 24 Nov 2009 09:40:08 -0500
User-agent: Mutt/1.5.19 (2009-01-05)

On Mon, Nov 23, 2009 at 01:08:30PM +0200, Gleb Natapov wrote:
> > > -    memcpy((char *)start, "CPU  " "\0" "" "\0" "", 7);
> > > - ((char *)start)[4] = cpu_number + '0';
> > > +    memcpy((char *)start, "CPU  \0QEMU\0\0", 12);
> > > +    ((char *)start)[4] = cpu_number + '0';
> > 
> > BTW, snprintf can now be used here.
> > 
> snprintf in SeaBIOS doesn't have return value. In some situation it is
> impossible to use it properly without it.

It's straight forward to add - commit 2be312c1.

-Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]