Re: [Qemu-devel] Re: [PATCH 5/6] Convert linux bootrom to external rom and fw_cfg

[Alexander Graf]

On 13.11.2009, at 07:37, Paolo Bonzini wrote:

> On 11/12/2009 09:53 PM, Alexander Graf wrote:
>> +    /* Set DS to SS+SP - 0x10, so we can write our GDT descriptor there */
>> +    mov             %ss, %eax
>> +    shl             $4, %eax
>> +    add             %esp, %eax
>> +    sub             $0x10, %eax
>> +    shr             $4, %eax
> 
> Dead code?  Or wrong comment and missing mov %eax, %gs?

The latter.

> Also, I know this is running with disabled interrupts, but why set %gs just 
> below the stack instead of decrementing %esp?

Uh. Decrementing %esp should work too I guess. That's just what I came up with.

Alex