qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] qcow2: Store exact backing format length


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Store exact backing format length
Date: Tue, 01 Dec 2009 10:45:52 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Currently qcow2 unnecessarily rounds up the length of the backing format 
> string
> to the next multiple of 8. At the same time, the array in BlockDriverState can
> only hold 15 characters, so in effect backing formats with 9 characters or 
> more
> don't work (e.g. host_device).
>
> Save the real string length and things start to work for all valid image 
> format
> names.
>
> Signed-off-by: Kevin Wolf <address@hidden>

Looks good to me.

> ---
>
> v2:
> - Don't rely on sizeof(ext) being a multiple of 8

Broken before your patch, so this is bonus fix.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]