qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execut


From: Marcelo Tosatti
Subject: Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution
Date: Wed, 2 Dec 2009 11:54:45 -0200
User-agent: Mutt/1.5.19 (2009-01-05)

On Wed, Dec 02, 2009 at 11:41:19AM -0200, Glauber Costa wrote:
> > KVM vcpu threads should block SIGUSR1, set the in-kernel signal mask 
> > with KVM_SET_SIGNAL_MASK ioctl, and eat the signal in
> > qemu_wait_io_event (qemu_flush_work should run after eating
> > the signal). Similarly to qemu-kvm's kvm_main_loop_wait.
> > 
> > Otherwise a vcpu thread can lose a signal (say handle SIGUSR1 when not
> > holding qemu_global_mutex before kernel entry).
> > 
> > I think this the source of the problems patch 8 attempts to fix.
> 
> I remember you had patches for both theses fixes.

Only qemu_wait_io_event split.

> Can you resend them, ontop of this series?

There is not much sense to split qemu_wait_io_event after what your
patch set does (it should be split before).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]