[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 29/41] virtio-net: in_use and first_multi only h
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 29/41] virtio-net: in_use and first_multi only handle unsigned values |
Date: |
Wed, 02 Dec 2009 19:55:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> On Wed, Dec 02, 2009 at 07:30:18PM +0100, Juan Quintela wrote:
>> We can change things to be int32_t if that makes more sense (they were sent
>> as uint32).
>>
>> vmstate checks that the type of the value that you sent and the function
>> that you use for sending match. In this case, it was sending a int32_t
>> with the function to send uint32_t. In this particular case it didn't
>> matter (value is 0/1). But vmstate don't know what cases matter/don't
>> matter. It just test _always_ that you are using the right function for
>> your type.
>>
>> If you think that it is better to change the type of the value to
>> int32_t and change the functions, that is also ok with me.
>> What I care is that type of function and field are the same.
>>
>> Later, Juan.
>
> int is a better type than int32 here.
will switch to int (I really hope that int32_t == int in all
architectures that we are interested in)
> Please make the save/load functions match.
> If you like, convert it to bool.
bool is only 1 byte, not four. I wasn't the one using 4 bytes for a bool.
Later, Juan.
- [Qemu-devel] Re: [PATCH 27/41] virtio-net: abstract vlans operations, (continued)
[Qemu-devel] [PATCH 28/41] virtio-net: make vlan operations on uint8_t, not uint32_t, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 29/41] virtio-net: in_use and first_multi only handle unsigned values, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 30/41] virtio-net: use save/load type chek functions for has_vent_hdr, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 32/41] virtio-net: split virtio_net_post_load, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 31/41] virtio-net: we know macs size at compile time, make it static, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 33/41] virtio-net: port to vmstate, Juan Quintela, 2009/12/02