Re: [Qemu-devel] Re: [PATCH 0/9] in-kernel irqchip, new spin

[Michael S. Tsirkin]

On Thu, Dec 03, 2009 at 10:04:21AM -0200, Glauber Costa wrote:
> >> Haven't tested. But since I see that msix need some special code in 
> >> qemu-kvm,
> >> it probably won't. But I assume we can just add a patch ontop of this to 
> >> add
> >> that code and make it work, right?
> >
> > Sure. However - are you making in-kernel irqchip the default?
> > If so, I think the best way to do it would be:
> > 1. add in-kernel irqchip, off by default
> > 2. fix msix with in-kernel
> > 3. make in-kernel on by default
> >
> Right now there are no knobs to disable it, since last time I checked,
> people were inclined to
> solve that by adding a machine type that does not do irqchip in
> kernel, if wanted.

Can't everything doable by machine type also doable from
command line switch? Disabling irqchip used to be
a valuable debugging tool.

> However, since it is probably not going to reach 0.12 anyway, we can
> come up with a patch
> that fixes msix, and bundle in this series before I actually enable
> the irqchip (which is one
> of the last patches)

Fine.

> -- 
> Glauber  Costa.
> "Free as in Freedom"
> http://glommer.net
> 
> "The less confident you are, the more serious you have to act."