Re: [Qemu-devel] [PATCH 1/4] Rename DriveInfo.onerror to on_write_error

[Anthony Liguori]

Gleb Natapov wrote:
> On Fri, Nov 27, 2009 at 01:25:36PM +0100, Kevin Wolf wrote:
>   
> > Either rename variables and functions to refer to write errors (which is what
> > they actually do) or introduce a parameter to distinguish reads and writes.
> >
> >     
> I prefer either to use two different functions or hide 0/1 parameter behind
> a macro:
>  #define drive_get_on_write_error(a) drive_get_on_error(a, 0);
>   

Or a static inline.  But honestly, having three globally scoped 
functions shouldn't be a problem.

Regards,

Anthony Liguori