qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Get coding style closer to the real world


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] Get coding style closer to the real world
Date: Fri, 4 Dec 2009 17:47:06 +0000
User-agent: KMail/1.12.2 (Linux/2.6.31-1-amd64; KDE/4.3.2; x86_64; ; )

On Monday 30 November 2009, Alexander Graf wrote:
> Currently we have this stupid role of disallowing:
> 
>   if (r)
>       break;

This has been discussed to death several times, in several different paces, 
and with no clear resolution or consensus, so I'm going to make an executive 
decision:

The coding style stays as-is. Braces are required. Please ensure that all 
patches follow the coding style. There may be exceptions, but there should be 
a *good* reason for deviation.


If there are real problems or ambiguities in the coding style then I am 
willing to consider fixing it. This particular change meets neither criteria.

By picking a single coding style we've pretty much guaranteed that most people 
will disagree with some of it. IMO consistency is more important.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]