[Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support

[Andreas Färber]

Am 06.12.2009 um 14:41 schrieb Mike Kronenberg:

> On 06.12.2009, at 14:00, Andreas Faerber wrote:
>
> > -            int rectCount;
> > +            NSInteger rectCount;
>
> I know that this is endorsed by apple since 10.5 but NSInteger will  
> break compiling on Tiger and older.

You appear to be right there... no trace of it in 10.4u SDK.

> Int on the other hand is only throwing a warning on Leopard if I'm  
> not mistaken.

On Leopard ppc it just warns and works because NSInteger == int.
On Leopard ppc64 it warns and fails at runtime because NSInteger != int.

> Especially with qemu, one has to have an eye on the type...  
> NSInteger can be an int or a long, depending on the host...
>
> #if __LP64__ || NS_BUILD_32_LIKE_64
>         typedef long NSInteger;
>         typedef unsigned long NSUInteger;
> #else
>         typedef int NSInteger;
>         typedef unsigned int NSUInteger;
> #endif

Right, so we do need NSInteger - I'll add a version check. Thanks for  
the feedback!

Andreas