[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star
|
From: |
Jan Kiszka |
|
Subject: |
[Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star |
|
Date: |
Mon, 07 Dec 2009 09:24:25 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 12/06/2009 04:51 PM, Jan Kiszka wrote:
>> KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too
>> small for all MSRs. But this is precisely the error we trigger with the
>> initial request in order to obtain that size. Do not fail in that case.
>>
>> This caused a subtle corruption of the guest state as MSR_STAR was not
>> properly saved/restored. The corruption became visible with latest kvm
>> optimizing the MSR updates.
>>
>
> I applied this to qemu-kvm since it missed 0.12-rc1.
>
OK, but this part is unused in qemu-kvm as we use our own (unaffected)
implementation there so far.
Jan
signature.asc
Description: OpenPGP digital signature