|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code & serial lines. |
Date: | Mon, 07 Dec 2009 15:39:39 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 |
On 12/07/09 15:07, Alexander Graf wrote:
On 07.12.2009, at 14:27, Gerd Hoffmann wrote:Default variables belong in the machine description IMHO. On S390, we can't create serial, parallel or vga (or any MMIO/PIO requiring) devices.See last patch of this series. Moving that into the machine description is certainly worth looking at. For now I'm happy that the #ifdef S390 code for the default virtio console is down to just two lines.Would it be that hard to move the list of default devices to the machine description? You could probably still keep the default_xxx variables in vl.c, but access them from e.g. pc.c.
Hmm? access from pc.c? What exactly do you have in mind?I think we could add flags to QEMUMachine to disable default devices not supported anyway, i.e. add no_parallel variable, then in vl.c do
if (machine->no_parallel) default_parallel = 0;So qemu would stop creating a useless parallel0 chardev which isn't used because the machine in question can't support parallel ports anyway.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |