qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Permit zero-sized qemu_malloc() & friends


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Permit zero-sized qemu_malloc() & friends
Date: Mon, 07 Dec 2009 11:40:48 -0600
User-agent: Thunderbird 2.0.0.23 (X11/20090825)

Avi Kivity wrote:
On 12/07/2009 07:17 PM, Anthony Liguori wrote:
Avi Kivity wrote:
I don't understand. People will develop patches for 0.12 for a while as bugs are reported and fixed.

What's the exact problem here?


Bug reported against qemu. Developer develops patch, while testing qemu crashes on unrelated assert(size == 0).

1) Developer develops a patch against 0.12, it works, and they submit it to upstream.
2) Upstream crashes because of assert(size==0).
3) Developer is publicly shamed for developing against a release instead of a git tree.

The problem is (1), not (2). Not to mention that we won't allow qemu_malloc() uses in upstream anymore which should make (2) impossible.

Regards,

Anthony Liguori






reply via email to

[Prev in Thread] Current Thread [Next in Thread]