qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH VERSION 2] Disk image shared and exclusive locks


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH VERSION 2] Disk image shared and exclusive locks.
Date: Tue, 08 Dec 2009 11:00:17 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4

Am 07.12.2009 15:16, schrieb Richard W.M. Jones:
> Here's a second go at this patch.  The only change is that we add a
> second parameter (backinglock=none|shared|exclusive) which can be used
> to control locking on the first level (only) of backing disk.

And what about the backing file of the backing file? ;-) This approach
feels wrong somehow. We need to infer the locking for backing file from
the COW file (none => none; shared/exclusive => shared; commit acquires
an exclusive lock temporarily, but still can't prevent corruption with
turned off VMs)

You probably should add the locking flags to bdrv_open calls in
qemu-img, too.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]