qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 20/20] VNC: Convert do_info_vnc() to QObject
Date: Thu, 10 Dec 2009 09:30:16 -0600
User-agent: Thunderbird 2.0.0.23 (X11/20090825)

malc wrote:
On Thu, 10 Dec 2009, Luiz Capitulino wrote:

Return a QDict with server information. Connected clients are returned
as a QList of QDicts.

The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and
put_addr_qdict()) are used to insert 'host' and 'service' information
in the returned QDict.

This patch is big, but I don't see how to split it.

Signed-off-by: Luiz Capitulino <address@hidden>
[..snip..]

+
+static int vnc_qdict_local_addr(QDict *qdict, int fd)
+{
+    struct sockaddr_storage sa;
+    socklen_t salen;
+
+    salen = sizeof(sa);
+    if (getsockname(fd, (struct sockaddr*)&sa, &salen) < 0)
+        return -1;

Coding style violation, here and all over the place.

Indeed, please fix.

--
Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]