|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject |
Date: | Thu, 10 Dec 2009 18:24:38 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091203 Fedora/3.0-3.13.rc2.fc12 Thunderbird/3.0 |
On 12/10/2009 06:20 PM, Anthony Liguori wrote:
By the same token, wouldn't you probably do: name = hpet_info.get('name', None)
For name, yes. For an optional feature where you're interested in knowing both its existence and its value (if it exists), no.
Let me put it another way, I don't think adding null to the json parser and incorporating it into this command is a good idea at this stage in the release so if we want to do something like this, we need to defer it to 0.13.I agree there are some instances where null could be useful. I think we can get away without it here though.
For 'name', definitely, since it's known to exist. It would be nice to have consistency in how features are presented, though.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |