qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 02/17] ne2000: switch to symbolic names for pci regi


From: Michael S. Tsirkin
Subject: [Qemu-devel] [PATCH 02/17] ne2000: switch to symbolic names for pci registers
Date: Thu, 10 Dec 2009 20:09:52 +0200
User-agent: Mutt/1.5.19 (2009-01-05)

No functional changes. I verified that the generated binary
does not change.

Signed-off-by: Michael S. Tsirkin <address@hidden>
---
 hw/ne2000.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/ne2000.c b/hw/ne2000.c
index d1416cf..78fe14f 100644
--- a/hw/ne2000.c
+++ b/hw/ne2000.c
@@ -724,7 +724,8 @@ static int pci_ne2000_init(PCIDevice *pci_dev)
     pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_REALTEK_8029);
     pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
     pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type
-    pci_conf[0x3d] = 1; // interrupt pin 0
+    /* TODO: RST# value should be 0. PCI spec 6.2.4 */
+    pci_conf[PCI_INTERRUPT_PIN] = 1; // interrupt pin 0
 
     pci_register_bar(&d->dev, 0, 0x100,
                            PCI_BASE_ADDRESS_SPACE_IO, ne2000_map);
-- 
1.6.6.rc1.43.gf55cc





reply via email to

[Prev in Thread] Current Thread [Next in Thread]