[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/17] cmd646: symbolic names for pci registers
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH 08/17] cmd646: symbolic names for pci registers |
Date: |
Thu, 10 Dec 2009 20:10:56 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
No functional changes. I verified that the generated binary
does not change.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/ide/cmd646.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 3b7c606..086ff62 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -209,8 +209,8 @@ static int pci_cmd646_ide_initfn(PCIDevice *dev)
pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CMD);
pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_CMD_646);
- pci_conf[0x08] = 0x07; // IDE controller revision
- pci_conf[0x09] = 0x8f;
+ pci_conf[PCI_REVISION_ID] = 0x07; // IDE controller revision
+ pci_conf[PCI_CLASS_PROG] = 0x8f;
pci_config_set_class(pci_conf, PCI_CLASS_STORAGE_IDE);
pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type
@@ -227,7 +227,8 @@ static int pci_cmd646_ide_initfn(PCIDevice *dev)
pci_register_bar(dev, 3, 0x4, PCI_BASE_ADDRESS_SPACE_IO, ide_map);
pci_register_bar(dev, 4, 0x10, PCI_BASE_ADDRESS_SPACE_IO, bmdma_map);
- pci_conf[0x3d] = 0x01; // interrupt on pin 1
+ /* TODO: RST# value should be 0 */
+ pci_conf[PCI_INTERRUPT_PIN] = 0x01; // interrupt on pin 1
irq = qemu_allocate_irqs(cmd646_set_irq, d, 2);
ide_bus_new(&d->bus[0], &d->dev.qdev);
--
1.6.6.rc1.43.gf55cc
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH 08/17] cmd646: symbolic names for pci registers,
Michael S. Tsirkin <=