[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic names |
|
Date: |
Thu, 10 Dec 2009 18:28:39 +0000 |
|
User-agent: |
KMail/1.12.2 (Linux/2.6.31-1-amd64; KDE/4.3.2; x86_64; ; ) |
On Thursday 10 December 2009, Michael S. Tsirkin wrote:
> The recent e1000 bug made the important of using
> symbolic macros for pci config access clear for me.
> So I started going over drivers and converting
> to symbolic constants instead of hard-coded ones.
> I did a large part until I run out of steam.
> Maybe some brave soul will take up converting
> the rest of them, or maybe I will: note that
> when converting bridges one should be careful
> to use bridge macros where appropriate.
Seeing as you're introducing a huge amount of churn, wouldn't it be better to
come up with a sane abstraction for initializing the the PCI config data (c.f.
pci_config_set_vendor_id)?
Paul