[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_con
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config(). |
Date: |
Mon, 14 Dec 2009 15:51:33 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Mon, Dec 14, 2009 at 09:48:22PM +0900, Isaku Yamahata wrote:
> They call only pci_default_{read, write}_config().
> So they aren't necessary.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/gt64xxx.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c
> index fb7f5bd..c8034e2 100644
> --- a/hw/gt64xxx.c
> +++ b/hw/gt64xxx.c
> @@ -1082,17 +1082,6 @@ static void gt64120_reset(void *opaque)
> gt64120_pci_mapping(s);
> }
>
> -static uint32_t gt64120_read_config(PCIDevice *d, uint32_t address, int len)
> -{
> - return pci_default_read_config(d, address, len);
> -}
> -
> -static void gt64120_write_config(PCIDevice *d, uint32_t address, uint32_t
> val,
> - int len)
> -{
> - pci_default_write_config(d, address, val, len);
> -}
> -
> static void gt64120_save(QEMUFile* f, void *opaque)
> {
> PCIDevice *d = opaque;
> @@ -1125,7 +1114,7 @@ PCIBus *pci_gt64120_init(qemu_irq *pic)
> pic, 144, 4);
> s->ISD_handle = cpu_register_io_memory(gt64120_read, gt64120_write, s);
> d = pci_register_device(s->pci->bus, "GT64120 PCI Bus",
> sizeof(PCIDevice),
> - 0, gt64120_read_config, gt64120_write_config);
> + 0, NULL, NULL);
>
> /* FIXME: Malta specific hw assumptions ahead */
>
> --
> 1.6.5.4
- [Qemu-devel] [PATCH 08/11] acpi: use range helper function., (continued)
- [Qemu-devel] [PATCH 08/11] acpi: use range helper function., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 01/11] pci: remove PCIBus::config_reg., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 10/11] piix_pci: use range helper function, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 05/11] pci: import Linux pci_regs.h, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 11/11] msix: use range helper function., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config()., Isaku Yamahata, 2009/12/14
- [Qemu-devel] Re: [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config().,
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCH 00/11] various pci clean ups., Michael S. Tsirkin, 2009/12/14