[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVIC
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID. |
Date: |
Mon, 14 Dec 2009 15:53:05 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Mon, Dec 14, 2009 at 09:48:19PM +0900, Isaku Yamahata wrote:
> There is no user and they're obsolete. So remove them.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
We are removing everything here later, is it worth it
to put in a separate patch?
Anyway:
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/pci.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci.h b/hw/pci.h
> index 0309674..91f3809 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -154,9 +154,7 @@ typedef struct PCIIORegion {
> #define PCI_CAP_LIST_ID 0 /* Capability ID */
> #define PCI_CAP_LIST_NEXT 1 /* Next capability in the list */
>
> -#define PCI_REVISION 0x08 /* obsolete, use PCI_REVISION_ID */
> #define PCI_SUBSYSTEM_VENDOR_ID 0x2c
> -#define PCI_SUBDEVICE_ID 0x2e /* obsolete, use PCI_SUBSYSTEM_ID */
>
> /* Bits in the PCI Status Register (PCI 2.3 spec) */
> #define PCI_STATUS_RESERVED1 0x007
> --
> 1.6.5.4
- [Qemu-devel] [PATCH 00/11] various pci clean ups., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 03/11] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 02/11] pci: clean up pci_bar_address(), Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 06/11] pci: use pci_regs.h, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID., Isaku Yamahata, 2009/12/14
- [Qemu-devel] Re: [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID.,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 09/11] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 08/11] acpi: use range helper function., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 01/11] pci: remove PCIBus::config_reg., Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 10/11] piix_pci: use range helper function, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 05/11] pci: import Linux pci_regs.h, Isaku Yamahata, 2009/12/14
- [Qemu-devel] [PATCH 11/11] msix: use range helper function., Isaku Yamahata, 2009/12/14