Re: [Qemu-devel] [PATCH 09/11] Cocoa: Shutdown when window is closed

[Andreas Färber]

Hi,

Am 14.12.2009 um 08:04 schrieb <address@hidden> <address@hidden 
>:

> On Dec 13, 2009, at 04:55, ext Andreas Färber wrote:
>
> > The application is not very useful once the guest window is closed.
> > QEMU is not a document-based application; terminating it  
> > automatically
> > saves the user another action and resembles SDL behavior.
> >
> > Signed-off-by: Andreas Färber <address@hidden>
> > Cc: Mike Kronenberg <address@hidden>
> > Cc: Alexander Graf <address@hidden>
> > ---
> > cocoa.m |    7 +++++++
> > 1 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/cocoa.m b/cocoa.m
> > index 70c249b..09ed3cd 100644
> > --- a/cocoa.m
> > +++ b/cocoa.m

> > @@ -835,6 +837,11 @@ static int cocoa_keycode_to_qemu(int keycode)
> >    [[NSWorkspace sharedWorkspace] openFile:[NSString  
> > stringWithFormat:@"%@/../doc/qemu/qemu-tech.html",
> >        [[NSBundle mainBundle] resourcePath]] withApplication:@"Help  
> > Viewer"];
> > }
> > +
> > +- (void)windowWillClose:(NSNotification *)notification
> > +{
> > +       [NSApp terminate:self];
> > +}
> > @end
>
> Another way to achieve the same thing is to instead of the above  
> changes just introduce a new method for the QemuCocoaAppController  
> like:
>
> - (BOOL)applicationShouldTerminateAfterLastWindowClosed: 
> (NSApplication *)theApplication
> {
>    return YES;
> }

That's ingenious. I had searched for something like this, but around  
NSWindow... thanks!

Any other comments? Would you like to add an SoB to the now four  
patches proposed by you?

Regards,

Andreas