[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-alpha: Fix compiler warning for gcc-4.3
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH] target-alpha: Fix compiler warning for gcc-4.3 (and older) |
Date: |
Tue, 15 Dec 2009 12:57:27 +0100 |
On Mon, Dec 14, 2009 at 10:54 AM, Stefan Weil <address@hidden> wrote:
> "Old" compilers obviously are not able to recognise
> that all cases are handled here:
>
> qemu/target-alpha/helper.c:70: error: ‘round_mode’ may be used uninitialized
> in this function
>
> A small modification helps the compiler to do its jobs.
>
> gcc-4.4 does not need this, but is still not standard on all platforms.
>
> Signed-off-by: Stefan Weil <address@hidden>
Acked-by: Laurent Desnogues <address@hidden>
> ---
> target-alpha/helper.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-alpha/helper.c b/target-alpha/helper.c
> index a658f97..be7d37b 100644
> --- a/target-alpha/helper.c
> +++ b/target-alpha/helper.c
> @@ -95,6 +95,7 @@ void cpu_alpha_store_fpcr (CPUState *env, uint64_t val)
> round_mode = float_round_nearest_even;
> break;
> case 3:
> + default: /* this avoids a gcc (< 4.4) warning */
> round_mode = float_round_up;
> break;
> }
> --
> 1.6.5
>
>
>
>