[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent mon
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor |
|
Date: |
Tue, 15 Dec 2009 14:56:27 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Tue, 15 Dec 2009 10:42:46 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> Before the code motion, we throw QERR_UNDEFINED_ERROR on
>> monitor_vprintf(NULL, ...). Afterwards, we don't. Could you explain
>> why that's okay?
>
> We never did that. A call like that will just segfault QEMU
> w/o this fix.
You're right. Brain fart on my part.
- [Qemu-devel] [PATCH 3/5] monitor: do_balloon(): Check for errors, (continued)
[Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor, Luiz Capitulino, 2009/12/14