|
| From: | Paolo Bonzini |
| Subject: | [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie |
| Date: | Wed, 16 Dec 2009 10:15:07 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 |
On 12/16/2009 09:45 AM, Kirill A. Shutemov wrote:
>>> -VPATH=$(SRC_PATH) >>> +vpath %.c $(SRC_PATH)> > This change is needed?Yes. We dont want to take %.o from $(SRC_PATH) since they built without -fpie.
I think that's fine, it's kind of the purpose of vpath to only look for sources in the vpath; so it's safer to use "vpath" than "VPATH". That said, I'd change it to
vpath %.c %.h $(SRC_PATH) and I'd do so uniformly in all the directories that currently use VPATH. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |