Re: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie

[Kirill A. Shutemov]

On Wed, Dec 16, 2009 at 11:15 AM, Paolo Bonzini <address@hidden> wrote:
> On 12/16/2009 09:45 AM, Kirill A. Shutemov wrote:
>>>>>
>>>>> >>>  -VPATH=$(SRC_PATH)
>>>>> >>>  +vpath %.c $(SRC_PATH)
>>>
>>> >
>>> >  This change is needed?
>>
>> Yes. We dont want to take %.o from $(SRC_PATH) since they built without
>> -fpie.
>
> I think that's fine, it's kind of the purpose of vpath to only look for
> sources in the vpath; so it's safer to use "vpath" than "VPATH".  That said,
> I'd change it to
>
> vpath %.c %.h $(SRC_PATH)

We don't have make-targets which require %.h in Makefile.user, so it's noise.

>
> and I'd do so uniformly in all the directories that currently use VPATH.
>
> Paolo
>
>
>
>