Re: [Qemu-devel] [PATCH] target-arm: ARMv4 emulation

[Aurelien Jarno]

On Fri, Dec 18, 2009 at 10:32:37PM +0100, Marc Andre Tanner wrote:
> On Tue, Dec 01, 2009 at 09:41:43PM +0100, Filip Navara wrote:
> > While most of the ARMv5 instructions are backward compatible with ARMv4, 
> > there
> > are few important differences. Most notably the stack pop and load 
> > instructions
> > ignore the lowest bit, which is used by ARMv5 to switch to Thumb mode. A
> > base-updated data-abort model is used on ARM7TDMI, CP15 coprocessor is not
> > present and several instructions of later architectures are not implemented.
> > 
> > This patch introduces flags for the V5, CP15 and ABORT_BU (base-updated 
> > abort
> > model) features. When V5 feature is not set the bit 0 on POP, LD and LDM of 
> > PC
> > register is ignored and doesn't swith to/from Thumb mode and several
> > instructions are treated as unimplemented (BLX, PLD, BKPT, LDRD, STRD).
> > 
> > Added are processor definitions for ARM7TDMI and ARM920T.
> > 
> > Based on patches by Ulrich Hecht <address@hidden> and Vincent Sanders 
> > <address@hidden>.
> 
> Could someone please review + apply this patch, bonus points if it ends
> up in 0.12.
> 

ARM stuff is usually reviewed by Paul Brook. Paul, do you plan to review
it, or should I do it?

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net