Re: [Qemu-devel] [PATCH 1/8] Support PCI based option rom loading

[Blue Swirl]

On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann <address@hidden> wrote:
> From: Anthony Liguori <address@hidden>
>
> Currently, we preload option roms into the option rom space in memory.  This
> prevents DDIM from functioning correctly which severely limits the number
> of roms we can support.
>
> This patch introduces a pci_add_option_rom() which registers the
> PCI_ROM_ADDRESS bar which points to our option rom.  It also converts over
> the cirrus vga adapter, the rtl8139, virtio, and the e1000 to use this
> new mechanism.

This means that the VGA roms are now visible for all targets, not just
when rom_enable_driver_roms is true. I'm not opposing this, but it may
create regressions.