qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-alpha: Emit tcg debug_insn_start.


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] target-alpha: Emit tcg debug_insn_start.
Date: Sat, 19 Dec 2009 16:47:04 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Wed, Dec 16, 2009 at 06:33:05PM -0800, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target-alpha/translate.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
> index 45cb697..ceff9bf 100644
> --- a/target-alpha/translate.c
> +++ b/target-alpha/translate.c
> @@ -2627,6 +2627,10 @@ static inline void 
> gen_intermediate_code_internal(CPUState *env,
>              gen_io_start();
>          insn = ldl_code(ctx.pc);
>          num_insns++;
> +
> +     if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP)))
> +       tcg_gen_debug_insn_start(ctx.pc);
> +

The coding style is wrong, you should use spaces instead of tabs. Also
use braces after if. Otherwise it's ok.

>          ctx.pc += 4;
>          ret = translate_one(ctxp, insn);
>          if (ret != 0)
> -- 
> 1.6.5.2
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]