Re: [Qemu-devel] [PATCH 2/3] eepro100: Better documentation for temporary data

[Stefan Weil]

Andreas Färber schrieb:
> Hello,
>
> Am 20.12.2009 um 16:52 schrieb Stefan Weil:
>
>> Michael S. Tsirkin suggested more documentation for
>> two temporary status values. Well, here it is.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> hw/eepro100.c |    7 ++++---
>> 1 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/eepro100.c b/hw/eepro100.c
>> index 5635f61..fb455a4 100644
>> --- a/hw/eepro100.c
>> +++ b/hw/eepro100.c
>> @@ -213,9 +213,10 @@ typedef struct {
>>     uint32_t ru_offset;         /* RU address offset */
>>     uint32_t statsaddr;         /* pointer to eepro100_stats_t */
>>
>> -    /* Temporary data. */
>> -    eepro100_tx_t tx;
>> -    uint32_t cb_address;
>
> Since you just introduced this in patch 1/3, please add the verbose
> documentation to the patch introducing these variables.
>
> Andreas

Hi Andreas,

in this special case I won't resend the patch.
It was already sent too often :-)

Regards
Stefan