[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/19] avoid dubiously clever code in win32_start_ti
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 03/19] avoid dubiously clever code in win32_start_timer |
Date: |
Mon, 21 Dec 2009 09:09:14 +0100 |
The code is initializing an unsigned int to UINT_MAX using "-1", so that
the following always-true comparison seems to be always-false at a
first look. Just remove the if.
Signed-off-by: Paolo Bonzini <address@hidden>
---
vl.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 97410ad..22ec53d 100644
--- a/vl.c
+++ b/vl.c
@@ -813,7 +813,7 @@ static struct qemu_alarm_timer *alarm_timer;
struct qemu_alarm_win32 {
MMRESULT timerId;
unsigned int period;
-} alarm_win32_data = {0, -1};
+} alarm_win32_data = {0, 0};
static int win32_start_timer(struct qemu_alarm_timer *t);
static void win32_stop_timer(struct qemu_alarm_timer *t);
@@ -1550,9 +1550,7 @@ static int win32_start_timer(struct qemu_alarm_timer *t)
memset(&tc, 0, sizeof(tc));
timeGetDevCaps(&tc, sizeof(tc));
- if (data->period < tc.wPeriodMin)
- data->period = tc.wPeriodMin;
-
+ data->period = tc.wPeriodMin;
timeBeginPeriod(data->period);
flags = TIME_CALLBACK_FUNCTION;
--
1.6.5.2
- [Qemu-devel] [PATCH 00/19][RFC] Cleanups + split timer handling out of vl.o, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 01/19] centralize handling of -icount, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 02/19] add qemu_icount_round, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 03/19] avoid dubiously clever code in win32_start_timer,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/19] only one flag is needed for alarm_timer, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 04/19] fix error in win32_rearm_timer, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 07/19] add qemu_get_clock_ns, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 09/19] remove qemu_rearm_alarm_timer from main loop, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 08/19] move kbd/mouse events to event.c, Paolo Bonzini, 2009/12/21
- [Qemu-devel] [PATCH 11/19] use a bottom half to run timers, Paolo Bonzini, 2009/12/21