Re: [Qemu-devel] Re: [PATCH v2] loader: don't call realloc(non_null, 0) when no symbols are present

[Aurelien Jarno]

On Tue, Dec 29, 2009 at 04:40:33PM +0000, Jamie Lokier wrote:
> Aurelien Jarno wrote:
> > On Tue, Dec 29, 2009 at 05:36:40PM +0200, Michael S. Tsirkin wrote:
> > > On Mon, Dec 28, 2009 at 09:20:20PM +0100, Aurelien Jarno wrote:
> > > > According to C99, realloc(non_null, 0) != free(non_null), that's why
> > > > it is forbidden in QEMU.
> > > > 
> > > > When there are no symbols, nsyms equals to 0. Free the syms structure
> > > > and set it to NULL instead of reallocating it with a size of 0.
> > > > 
> > > > This fixes -kernel with stripped kernels.
> > > > 
> > > > Signed-off-by: Aurelien Jarno <address@hidden>
> > > 
> > > I didn't know, you live and learn. FWIW
> > 
> > Can you please stop being annoying about that?
> 
> What was the annoyance?  I don't see what it is and would like to
> avoid being annoying.

A misunderstanding between Michael and me. Sorry about that.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net