[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.
From: |
Nathan Baum |
Subject: |
Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends. |
Date: |
Tue, 29 Dec 2009 19:36:08 +0000 |
On Tue, 2009-12-29 at 15:13 -0200, Luiz Capitulino wrote:
> > + qdict_put(qdict, "gpio-in", qint_from_int(dev->num_gpio_in));
> > + qdict_put(qdict, "gpio-out", qint_from_int(dev->num_gpio_out));
>
> Is this a boolean? If so you should use qbool_from_int().
It isn't, but they shouldn't be there anyway. I mistook them for IOPS
counters without checking, but it actually counts the number of entries
in the gpio_in/gpio_out array. They don't appear useful.
- Re: [Qemu-devel] [PATCH 06/11] qdev: sysbus_dev_info, (continued)
- [Qemu-devel] [PATCH 03/11] qdev: Add isabuf_dev_info to ISA's BusInfo struct., Nathan Baum, 2009/12/26
- [Qemu-devel] [PATCH 07/11] qdev: Add sysbus_dev_info to system_bus_info, Nathan Baum, 2009/12/26
- [Qemu-devel] [PATCH 08/11] qdev: Add usb_bus_dev_info, Nathan Baum, 2009/12/26
- [Qemu-devel] [PATCH 04/11] qdev: pcibus_dev_info, Nathan Baum, 2009/12/26
- [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends., Nathan Baum, 2009/12/26
- [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree., Nathan Baum, 2009/12/26
- [Qemu-devel] [PATCH 09/11] qdev: Add usb_bus_dev_info to usb_bus_info., Nathan Baum, 2009/12/26
- Re: [Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP., Luiz Capitulino, 2009/12/29
- [Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP., Nathan Baum, 2009/12/26