qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.


From: Nathan Baum
Subject: Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.
Date: Tue, 29 Dec 2009 19:36:08 +0000

On Tue, 2009-12-29 at 15:13 -0200, Luiz Capitulino wrote:

> > +    qdict_put(qdict, "gpio-in", qint_from_int(dev->num_gpio_in));
> > +    qdict_put(qdict, "gpio-out", qint_from_int(dev->num_gpio_out));
> 
>  Is this a boolean? If so you should use qbool_from_int().

It isn't, but they shouldn't be there anyway. I mistook them for IOPS
counters without checking, but it actually counts the number of entries
in the gpio_in/gpio_out array. They don't appear useful.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]