Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

[Luiz Capitulino]

On Wed, 30 Dec 2009 12:01:28 +0000
Blue Swirl <address@hidden> wrote:

> On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov <address@hidden> wrote:
> > Knowing ioapic configuration is very useful for the poor soles
> > how need to debug guest occasionally.
> 
> > +static struct IOAPICState *ioapic;
> 
> Ugly. I really think the monitor interface needs to be changed to take
> an opaque parameter.
> 
> The parameter can passed to the caller with for example a registration
> function, like the patches I sent before QObject conversion.

 Do you mind updating your series and sending it again?

 You could make the opaque parameter part of info_new or cmd_new, provided
the new handlers have global data so that we can see better the benefit
in practice.