Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

[Gleb Natapov]

On Wed, Dec 30, 2009 at 05:04:08PM +0200, Avi Kivity wrote:
> On 12/30/2009 01:50 PM, Gleb Natapov wrote:
> >Knowing ioapic configuration is very useful for the poor soles
> >how need to debug guest occasionally.
> >+
> >+void do_info_ioapic(Monitor *mon, QObject **ret_data)
> >+{
> >+    int i;
> >+    QList *list;
> >+
> >+    *ret_data = NULL;
> >+
> >+    if (!ioapic)
> >+        return;
> >+
> >+    list = qlist_new();
> >+
> >+    for (i = 0; i<  IOAPIC_NUM_PINS; i++) {
> >+        QObject *obj;
> 
> 
> This assumes there is only one ioapic.  While I don't think there's
> a good reason to add more (the one we have is causing sufficient
> trouble), I suggest returning an array of ioapics (or include
> gsibase: [{ ioapic: object, gsibase: 0 }, { ioapic: object, gsibase:
> 24 }].
> 
For the case of multiple ioapics I thought about extending the command
to get ioapic id as a parameter when time comes. gsibase is not know to
ioapic itself, so this info does not belong here.

--
                        Gleb.