Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

[Gleb Natapov]

On Wed, Dec 30, 2009 at 05:07:14PM -0600, Anthony Liguori wrote:
> On 12/30/2009 06:13 AM, Gleb Natapov wrote:
> >On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote:
> >>On Wed, 30 Dec 2009 14:05:10 +0200
> >>Gleb Natapov<address@hidden>  wrote:
> >>
> >>>On Wed, Dec 30, 2009 at 12:01:28PM +0000, Blue Swirl wrote:
> >>>>On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov<address@hidden>  wrote:
> >>>>>Knowing ioapic configuration is very useful for the poor soles
> >>>>>how need to debug guest occasionally.
> >>>>
> >>>>>+static struct IOAPICState *ioapic;
> >>>>
> >>>>Ugly.
> >>>>
> >>>Agree
> >>
> >>And now it seems like even you dont agree with me!!!
> >>
> >I agree, but all other info functions in qemu do exactly same:
> >referencing global data. This is ugly _and_ this nothing to
> >do with my patch.
> 
> This goes away if you use VMState since we already have a global
> table that contains all of the registered VMState instances.  It
> also maps device names/instance ids to the actual field contents.
> 
I've got you point. When VMState will have this cool powers you are talking
about I'll use it. I don't see the point of bragging about something
that doesn't exists.

--
                        Gleb.